Fix Alipay user_id upgrade open_id issue#1015
Merged
martincostello merged 1 commit intoaspnet-contrib:devfrom Feb 18, 2025
Merged
Fix Alipay user_id upgrade open_id issue#1015martincostello merged 1 commit intoaspnet-contrib:devfrom
martincostello merged 1 commit intoaspnet-contrib:devfrom
Conversation
Member
Could you please summarise this document into English as to what is being changed and why? Changes also need tests. |
Contributor
Author
Additionally, how can I add test cases? I have already applied the changes to my production environment. |
Member
The existing tests for Alipay are here. You can see we stub out the responses, so you'd have to extend the tests to exercise these new changes. |
Contributor
Author
|
How do I modify |
Contributor
Author
|
I couldn't find a test for exceptional data. I also hope I can provide an elegant test |
Contributor
Author
|
The extended test of Alipay has been added |
src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs
Outdated
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Alipay/AlipayTests.cs
Outdated
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Alipay/AlipayTests.cs
Outdated
Show resolved
Hide resolved
Loongle
force-pushed
the
dev
branch
2 times, most recently
from
9c46e50 to
50d53f2
Compare
Contributor
Author
|
Could you please review it again? @martincostello |
martincostello
approved these changes
Feb 18, 2025
Member
|
Thanks for your contribution - this change will go out when #1020 is completed. If you want to use it before then, then please consume the prerelease packages from our MyGet feed. |
Member
|
Thanks again for your contribution - the changes are now available from NuGet.org in v9.1.0. |
intellitect-bot
pushed a commit
to IntelliTect/EssentialCSharp.Web
that referenced
this pull request
Feb 6, 2026
Updated [AspNet.Security.OAuth.GitHub](git://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers) from 8.3.0 to 9.4.1. <details> <summary>Release notes</summary> _Sourced from [AspNet.Security.OAuth.GitHub's releases](git://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/releases)._ ## 9.4.1 ## What's Changed * Perf optimization for Bilibili provider by @LeaFrock in aspnet-contrib/AspNet.Security.OAuth.Providers#1071 * Bilibili refactor by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1072 * Add CodeQL for GitHub Actions by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1095 * Use NuGet Trusted Publishing by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1110 * feat(Keycloak): add "family_name" mapping to ClaimTypes.Surname by @XB-RS in aspnet-contrib/AspNet.Security.OAuth.Providers#1112 ## New Contributors * @XB-RS made their first contribution in aspnet-contrib/AspNet.Security.OAuth.Providers#1112 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.4.0...9.4.1 ## 9.4.0 ## What's Changed * Add Bilibili provider by @Loongle in aspnet-contrib/AspNet.Security.OAuth.Providers#1044 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.3.0...9.4.0 ## 9.3.0 ## What's Changed * Add Contentful provider by @jerriep in aspnet-contrib/AspNet.Security.OAuth.Providers#1063 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.2.0...9.3.0 ## 9.2.0 ## What's Changed * Use `Convert.ToHexStringLower` by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1048 * Add Linear provider by @jerriep in aspnet-contrib/AspNet.Security.OAuth.Providers#1045 * Add Miro provider by @jerriep in aspnet-contrib/AspNet.Security.OAuth.Providers#1046 * Add Webflow provider by @jerriep in aspnet-contrib/AspNet.Security.OAuth.Providers#1047 ## New Contributors * @jerriep made their first contribution in aspnet-contrib/AspNet.Security.OAuth.Providers#1045 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.1.0...9.2.0 ## 9.1.0 ## What's Changed * Allow roll-forward for dotnet-validate by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#989 * Update bundle data in KOOK provider test by @gehongyan in aspnet-contrib/AspNet.Security.OAuth.Providers#1021 * Fix Alipay user_id upgrade open_id issue by @Loongle in aspnet-contrib/AspNet.Security.OAuth.Providers#1015 * Add GitCode Provider by @gehongyan in aspnet-contrib/AspNet.Security.OAuth.Providers#1020 * Enable package validation by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#1031 * Add Atlassian provider #839 by @smnsht in aspnet-contrib/AspNet.Security.OAuth.Providers#1037 ## New Contributors * @Loongle made their first contribution in aspnet-contrib/AspNet.Security.OAuth.Providers#1015 * @smnsht made their first contribution in aspnet-contrib/AspNet.Security.OAuth.Providers#1037 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@9.0.0...9.1.0 ## 9.0.0 ## What's Changed * Update to .NET 9 by @martincostello in aspnet-contrib/AspNet.Security.OAuth.Providers#833 **Full Changelog**: aspnet-contrib/AspNet.Security.OAuth.Providers@8.3.0...9.0.0 Commits viewable in [compare view](git://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/compare/8.3.0...9.4.1). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References: https://opendocs.alipay.com/common/0ai2i6?pathHash=cba76ebf